Fix renderFrame logic in PassthroughSoftwareRenderer #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Ma7moudHatem
commented
Mar 9, 2021
Ma7moudHatem
commented
- Fix an issue in renderFrame() method inside PassthroughSoftwareRenderer class, where it throws a BufferOverflowException when the InputBuffer's size is larger than the OutputBuffer's size.
- Add a try-catch to some release() methods, where it's safe to catch the exception and not throw it, also to not make wrong behavior where the onError method of TransformationListener will not be called.
- This pull request will fix the opened issue in litr, Failed to transcode some video files #102
…erer class, where it throw a BufferOverflowException when the InputBuffer's size is larger than the OutputBuffer's size
… the exception and not throw it, also to not make wrong behaviour where the onError method of TransformationListener will not be called
izzytwosheds
reviewed
Mar 9, 2021
litr/src/main/java/com/linkedin/android/litr/TransformationJob.java
Outdated
Show resolved
Hide resolved
litr/src/main/java/com/linkedin/android/litr/codec/MediaCodecDecoder.java
Show resolved
Hide resolved
litr/src/main/java/com/linkedin/android/litr/render/PassthroughSoftwareRenderer.java
Outdated
Show resolved
Hide resolved
litr/src/main/java/com/linkedin/android/litr/render/PassthroughSoftwareRenderer.java
Outdated
Show resolved
Hide resolved
litr/src/main/java/com/linkedin/android/litr/render/PassthroughSoftwareRenderer.java
Outdated
Show resolved
Hide resolved
litr/src/main/java/com/linkedin/android/litr/render/PassthroughSoftwareRenderer.java
Outdated
Show resolved
Hide resolved
litr/src/main/java/com/linkedin/android/litr/render/PassthroughSoftwareRenderer.java
Outdated
Show resolved
Hide resolved
izzytwosheds
reviewed
Mar 9, 2021
litr/src/main/java/com/linkedin/android/litr/render/PassthroughSoftwareRenderer.java
Outdated
Show resolved
Hide resolved
litr/src/main/java/com/linkedin/android/litr/render/PassthroughSoftwareRenderer.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.