Enhance the logic for finding a media codec for a media format #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re sometimes the findEncoderForFormat/findDeccoderForFormat or createEncoderByType/createDecoderByType methods will return the first MediaCodec in the available media codecs that could support the media type, but this codec may not be able to configure the media format, so the fix here is to get all available codecs that support the mimeType, and iterate over them to check which codec could configure the media format and return it
| if (mediaCodec != null) { | ||
| mediaCodec.configure(mediaFormat, surface, null, isEncoder ? MediaCodec.CONFIGURE_FLAG_ENCODE : 0); | ||
| @NonNull | ||
| private static MediaCodec getAndConfigureCodec( |
There was a problem hiding this comment.
Rename this to createAndConfigureCodec, more accurate to what method does
izzytwosheds
approved these changes
Mar 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance the logic for finding a media codec for a media format, where sometimes the findEncoderForFormat/findDeccoderForFormat or createEncoderByType/createDecoderByType methods will return the first MediaCodec in the available media codecs that could support the media type, but this codec may not be able to configure the media format, so the fix here is to get all available codecs that support the mimeType, and iterate over them to check which codec could configure the media format and return it