Add support to write data to a File using a Uri #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to support scoped-storage enforcement in Android 10+, by using Uri instead of directly writing to File which will cause an exception
litr/src/main/java/com/linkedin/android/litr/io/MediaMuxerMediaTarget.java
Show resolved
Hide resolved
litr/src/main/java/com/linkedin/android/litr/io/MediaMuxerMediaTarget.java
Outdated
Show resolved
Hide resolved
litr/src/main/java/com/linkedin/android/litr/io/MediaMuxerMediaTarget.java
Outdated
Show resolved
Hide resolved
litr/src/main/java/com/linkedin/android/litr/utils/FileUtils.java
Outdated
Show resolved
Hide resolved
litr/src/main/java/com/linkedin/android/litr/utils/FileUtils.java
Outdated
Show resolved
Hide resolved
| if (parcelFileDescriptor != null) { | ||
| mediaMuxer = new MediaMuxer(parcelFileDescriptor.getFileDescriptor(), outputFormat); | ||
| } else { | ||
| throw new IOException(); |
There was a problem hiding this comment.
Maybe MediaTargetException here as well? Use IO_FAILURE enum value
There was a problem hiding this comment.
@izzytwosheds, already the MediaTargetException with IO_FAILURE will be thrown after throwing the IOException because there is an IOException catch case with the try, else if you prefer to directly throw the MediaTargetException here.
There was a problem hiding this comment.
Gotcha, I see it now. Should we add a helpful message to IOException? Something like "Inaccessible URI" + outputFileUri ?
There was a problem hiding this comment.
I think yes, and it's fixed now
izzytwosheds
approved these changes
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to write data to a File using a Uri, where most likely to support scoped-storage enforcement in Android 10+, by using Uri instead of directly writing to File which will cause an exception.