Fixed angle computation #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just a wrong degree to radian formula
|
Did this code actually run? |
It shouldn't as I understand, but it might if user is using some not accurate math equations to compute angle. For example, it might be called if previously user transformed angle from radians to degrees. |
|
Or if user just want to rotate video in a strange way:) |
|
That angle is supposed to be video orientation (portrait, landscape, etc.), which is expected to be multiples of 90 degrees. But I guess one can expect any kind of user input. :) |
|
Thank you for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a wrong degree to radian formula