Recreate AudioProcessor on source/target audio format change #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
AudioRendererinitializesAudioProcessoronce, when created. What happens in reality sometimes (as reported in #188) audio track format reported in track metadata does not correspond to actual track format reported by MediaCodec. This causes audio processing to fail because we initializeAudioProcessorfor one set of sampling rate / channel count combination but actual sampling rate / channel count could be different which causes aBufferOverflowException.Solution is to re-create
AudioProcessoreach time either source or target format changes. This ensures that it is configured correctly.