Allocate/deallocate native input/output buffers on init/release #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReallyVasiliy
approved these changes
Jul 11, 2022
Comment on lines
101
to
105
| delete resamplerInputBuffer; | ||
| resamplerInputBuffer = nullptr; | ||
| } | ||
| if (resamplerOutputBuffer != nullptr) { | ||
| delete resamplerOutputBuffer; |
There was a problem hiding this comment.
nit: should these be delete[] (e.g. delete[] resamplerInputBuffer) instead?
There was a problem hiding this comment.
good catch. It should. Changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were allocating native buffers for Oboe audio processor on each frame and not de-allocating them, as was pointed out in #201
Instead, now we are allocating them when we initialize the resampler (when we know the buffer size) and deallocating them when we release the resampler.