Use source (or default) frame rate when creating video MediaFormat #213
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we were creating
MediaFormat
in cases whentargetMediaFormat
wasnull
(keep source format) but overlays were present, we did not populate frame rate. This could be problematic when configuring an encoder, they usually need frame rate to be present.Now populating it with either source format value, or default of 30 if source format does not have it.