Allow transcoders advance to next track or EoS past selection end #230
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of recent bug reports (#216 ) has an interesting use case - metadata track that starts after selection range end. Current logic never advances far past the end of selection, so we never process that metadata track thus "hanging" indefinitely.
Changing trim logic to handle cases like this:
TransformationJob
, to indicate that processing of that track is done and it is ok to complete the job.TransformationJob
is not completed, it asks aTrackTranscoder
toprocessNextFrame
. IfTrackTranscoder
is in "end of range" state, it will simply advance to next track or its own EoS (whichever is first) without processing any frames. This way we can reach frames in all tracks.Fix was tested manually with the test file provided in that bug report, fix worked. Unit tests were added.