Muxers: Add native headers required for building (Alt) #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanDBird
commented
Jan 21, 2023
| @@ -26,7 +26,7 @@ android { | |||
| externalNativeBuild { | |||
| cmake { | |||
| path file('src/main/cpp/CMakeLists.txt') | |||
| version '3.10.2' | |||
| version '3.18.1' | |||
There was a problem hiding this comment.
Updated cmake required for file(ARCHIVE_EXTRACT ...)
izzytwosheds
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative approach to #242.
Instead of including all the ffmpeg headers in the repo, we will download a snapshot locally. The ideal approach is that the user checks out and builds ffmpeg themselves, but this fallback allows us to ensure that a new checkout will build and use the correct headers for the bundled binaries.