Muxers: Add native muxer implementation #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanDBird
commented
Jan 24, 2023
|
|
||
| # Include additional headers that would be generated via the configure (which won't be there in | ||
| # the downloaded artifact. | ||
| include_directories("${CMAKE_CURRENT_SOURCE_DIR}/ffmpeg_bundled/extra") |
There was a problem hiding this comment.
Hopefully the last cmake change 😅 Turned out that the configure auto-generated this header, so included in the repo to augment the vanilla source that we download (when the user doesn't have their own checkout).
izzytwosheds
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #235
This code includes the native code for the libavformat based muxer. It provides a wrapper around the required functionality, as well as the JNI code required for exposing it to the KT/Java classes (coming in later PR).
I wasn't sure how much commenting / documentation you would like for the C++ code, so if more is required, just let me know and I can do another pass.