Muxers: integrate native muxer with LiTr #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izzytwosheds
reviewed
Mar 2, 2023
| public static final String VIDEO_VP9 = BASE_TYPE_VIDEO + "/x-vnd.on2.vp9"; | ||
| public static final String VIDEO_RAW = BASE_TYPE_VIDEO + "/raw"; | ||
|
|
||
| public static boolean IsVideo(@Nullable String mimeType) { |
There was a problem hiding this comment.
jc: why do method names start with capital letter?
There was a problem hiding this comment.
Its a habit when naming static methods. Can change to lower case to be similar to LiTr
There was a problem hiding this comment.
yeah, let's keep it consistent with the rest of the code.
IanDBird
force-pushed
the
ian/muxers-integration
branch
from
fedcdce
to
c63d8e4
Compare
IanDBird
force-pushed
the
ian/muxers-integration
branch
from
c63d8e4
to
6bf8db0
Compare
izzytwosheds
approved these changes
Mar 6, 2023
| const val KEY_CHANNEL_COUNT = MediaFormat.KEY_CHANNEL_COUNT | ||
| const val KEY_SAMPLE_RATE = MediaFormat.KEY_SAMPLE_RATE | ||
|
|
||
| fun MediaFormat.isVideo(): Boolean { |
There was a problem hiding this comment.
Note: Doesn't have to happen in this PR, but this a very useful class that could be moved into main litr module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After adding ffmpeg and the native wrapper code, this PR integrates it with LiTr along with exposing it via the demo app. The demo app now provides options to try the native muxer with a normal file transcode, as well as a camera capture. For the camera example, I've also configured the native muxer to generate a single fMP4 which demonstrates something that isn't possible with Android's built in MediaMuxer.
You'll notice that
orientationHintis not yet used in the new muxer. I plan to add this next, as will require some plumbing/support for file based metadata, rather than stream information.