Always set TargetFormat value in TrackTransformationInfo object #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts. If the format is not set here initially then it is never available in cases where we fail to create a corresponding TrackTranscoder.
vamshi-dhulipala
changed the title
izzytwosheds
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the value of TargetFormat field in the TrackTransformationInfo object is only set in the release method of the TransformationJob class. Also, the value is only set if a corresponding TrackTranscoder object is created successfully.
Updated logic to always set the value of TargetFormat field in the TrackTransformationInfo object when initiating stats. If the format is not set here initially, then in some scenarios where we fail to create a corresponding TrackTranscoder, the target format value will be reported back as null as part of the MediaTransformationListener callbacks.