refining array model #153
Merged
refining array model #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
cmungall
commented
Mar 31, 2023
cmungall
commented
- refinements to array metamodel
- test example from @rly
|
cc @oruebel |
rly
reviewed
Apr 14, 2023
rly
reviewed
Apr 14, 2023
| meaning: gom:columnMajorArray | ||
| description: >- | ||
| An array layout option in which the elements in each row are stored in consecutive positions, | ||
| or any generalization thereof to dimensionality greater than 2 |
There was a problem hiding this comment.
Suggested change
| or any generalization thereof to dimensionality greater than 2 | |
| or any generalization thereof to dimensionality greater than 2 | |
| aliases: | |
| - F order |
rly
reviewed
Apr 14, 2023
rly
reviewed
Apr 14, 2023
linkml_model/model/schema/array.yaml
Outdated
| COLUMN_MAJOR_ARRAY_ORDER: | ||
| meaning: gom:columnMajorArray | ||
| description: >- | ||
| An array layout option in which the elements in each row are stored in consecutive positions, |
There was a problem hiding this comment.
Suggested change
| An array layout option in which the elements in each row are stored in consecutive positions, | |
| An array layout option in which the elements in each column are stored in consecutive positions, |
rly
reviewed
Apr 14, 2023
rly
reviewed
Apr 14, 2023
rly
approved these changes
Apr 14, 2023
Co-authored-by: Ryan Ly <[email protected]>
Co-authored-by: Ryan Ly <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.