Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): add support for absolute outputDir and sourcefile #4

Conversation

guy-mograbi-at-gigaspaces
Copy link
Contributor

fixes #3

@linslin
Copy link
Owner

linslin commented Oct 28, 2015

Hey @guy-mograbi-at-gigaspaces, could you push this changes into develop branch? I drive gitflow. Thanks!

@guy-mograbi-at-gigaspaces
Copy link
Contributor Author

develop on my fork?
or a fix branch on my fork?

@linslin
Copy link
Owner

linslin commented Oct 28, 2015

Just push the changes into this branch: https://github.com/linslin/grunt-jscpd-reporter/tree/develop instead of master.

@guy-mograbi-at-gigaspaces
Copy link
Contributor Author

Not sure I understand. I don't think I have permissions to do so and I don't understand how that has anything to do with gitflow.

@linslin
Copy link
Owner

linslin commented Oct 28, 2015

Simple explained: Gitflow assumes features to be merged with a develop branch before mergin into master. In that way I can check if develop is still stable and merge your changes with other features. The hole tested bundle will be released as a nice and almost stable version into master branch.

Please check this link: https://help.github.com/articles/using-pull-requests/#changing-the-branch-range-and-destination-repository.

or via CLI:

git merge https://github.com/linslin/grunt-jscpd-reporter/tree/develop to create a pull request to develop branch.

@guy-mograbi-at-gigaspaces
Copy link
Contributor Author

oh! change the destination branch... now I see. doing it..

@guy-mograbi-at-gigaspaces
Copy link
Contributor Author

seems like I need to close this PR and open another
isaacs/github#18

@guy-mograbi-at-gigaspaces
Copy link
Contributor Author

see #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

breaks if sourcefile is absolute
2 participants