Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra characters in default value #154

Closed
ifedchankau opened this issue Aug 17, 2018 · 6 comments
Closed

Extra characters in default value #154

ifedchankau opened this issue Aug 17, 2018 · 6 comments
Assignees
Milestone

Comments

@ifedchankau
Copy link
Collaborator

Sometimes, default value may be written as:
*"table"
*'bower_components'
*[]

In first two cases, default be cointain extra quotes, in third case default will be [. Please, fix it.

ifedchankau added a commit to ifedchankau/usage-parser that referenced this issue Aug 17, 2018
Remove extra characters from default value

Closes linterhub#154
@itekaf
Copy link
Contributor

itekaf commented Aug 17, 2018

I think we need to identity type of properties before remove quotes. Because if it's string, we non to remove quotes

@itekaf itekaf added this to the v 1.0.0 milestone Aug 17, 2018
@ifedchankau
Copy link
Collaborator Author

@svoboda-rabstvo no, this issue about additional quotes which will be added to string in quotes. So, first 2 cases in result JSON-file will be:

  • "default": "\"table\""
  • "default": "\'bower_components\'"

@itekaf
Copy link
Contributor

itekaf commented Aug 17, 2018

Yes, but I suggest to remove additional and single quotes later, when we know a type of property. Because some default will be: "2" or "false"

@ifedchankau
Copy link
Collaborator Author

@svoboda-rabstvo good proposal, but, i think it is related to #151.

ifedchankau added a commit to ifedchankau/usage-parser that referenced this issue Aug 17, 2018
Remove extra characters from default value

Closes linterhub#154
@itekaf
Copy link
Contributor

itekaf commented Aug 17, 2018

@Arcle1 Yes, we need to find implementation for both issue :)

ifedchankau added a commit to ifedchankau/usage-parser that referenced this issue Aug 17, 2018
Remove extra characters from default value

Closes linterhub#154
ifedchankau added a commit to ifedchankau/usage-parser that referenced this issue Aug 17, 2018
Remove extra characters from default value

Closes linterhub#154
ifedchankau added a commit to ifedchankau/usage-parser that referenced this issue Aug 17, 2018
Remove extra characters from default value

Closes linterhub#154
@itekaf
Copy link
Contributor

itekaf commented Aug 20, 2018

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants