Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复插件sizePolicy无效的问题 #446

Merged
merged 1 commit into from
May 20, 2022

Conversation

q77190858
Copy link
Contributor

@q77190858 q77190858 commented May 12, 2022

第三方插件设置了sizePolicy,但是仍然被遮挡,这是因为dock中未对插件的sizePolicy作出判断,当前已修改

Log: 修复第三方插件sizePolicy无效问题
Influence: 第三方插件宽高

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cppcheck Result

You Made It Happen!

@zccrs
Copy link
Member

zccrs commented May 19, 2022

@ssk-wh commit信息检查不过,可以协助改一下。

@zccrs zccrs requested a review from ssk-wh May 19, 2022 08:53
@ssk-wh
Copy link
Contributor

ssk-wh commented May 19, 2022

看了下commit message,大概是fix:后面缺少了一个空格?

@zccrs
Copy link
Member

zccrs commented May 19, 2022

/+1

@ssk-wh ssk-wh changed the title fix:修复插件sizePolicy无效的问题 fix: 修复插件sizePolicy无效的问题 May 19, 2022
@ssk-wh
Copy link
Contributor

ssk-wh commented May 19, 2022

@q77190858 将fix:后面加个空格,更新一下呢,目前只是这个提交规范的问题,代码是OK的

@ssk-wh ssk-wh changed the title fix: 修复插件sizePolicy无效的问题 fix: 13 修复插件sizePolicy无效的问题 May 19, 2022
@ssk-wh ssk-wh changed the title fix: 13 修复插件sizePolicy无效的问题 fix: 修复插件sizePolicy无效的问题 May 19, 2022
@q77190858
Copy link
Contributor Author

@q77190858 将fix:后面加个空格,更新一下呢,目前只是这个提交规范的问题,代码是OK的

好的

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cppcheck Result

Hats Off To You!

第三方插件设置了sizePolicy,但是仍然被遮挡,这是因为dock中未对插件的sizePolicy作出判断,当前已修改

Log: 修复第三方插件sizePolicy无效问题
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cppcheck Result

Congratulations!

@ssk-wh
Copy link
Contributor

ssk-wh commented May 20, 2022

@q77190858 已经同意了,直接回复'/merge'应该就可以合并了

@deepin-bot deepin-bot bot merged commit d0db071 into linuxdeepin:master May 20, 2022
@ssk-wh
Copy link
Contributor

ssk-wh commented May 20, 2022

原来是检测到回复的消息中有这个字段就自动合了,下次让你来
977433a8-d8dd-461e-8c8a-32345d29c7dc

@q77190858
Copy link
Contributor Author

感谢,辛苦了:ok_hand:

@zccrs
Copy link
Member

zccrs commented May 20, 2022

感谢贡献!

zty199 added a commit to zty199/dde-dock-monitor-plugin that referenced this pull request Sep 2, 2022
适配作者的 dde-dock [pr补丁](linuxdeepin/dde-dock#446

Log: 修复 dde-dock 高度过低时插件显示不完整的问题;整理代码文件结构,支持 dpkg-buildpackage 打包
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants