Spearbit Audit september 2023

[0xvv]

Branch for the spearbit audit

• added getRiver() view function to RedeemManager
• added setOperatorStoppedValidatorCount event
• added an optional global unlock schedule to TLC schedules (will be merged in this branch soon)

More info on the global unlock schedule :

Due to legal & regulatory concerns it was to chosen to apply a global unlock schedule to most, but not all vesting schedules.
The global unlock schedule must release 1/24 th of the total amount of the vesting schedule every month for 2 years after the schedule local lock end. The unlocking is entirely separated from the vesting it just caps the withdrawal of the vested tokens.
Some schedules are not subject to the global unlock schedule, this is why we added the IgnoreGlobalUnlockSchedule mapping and altered the vesting schedule creation function to fit the new behaviour.
The global unlock schedule computation is done in the existing function where the local lock is taken into account.

Those changes are accompanied by a migration, contained in the migration contract, which should be applied before pointing to the new implementation.
The migration sets IgnoreGlobalUnlockSchedule for the schedules where it's needed and also updates some erroneous values currently set.

[codecov]

Codecov Report

Merging #232 (4f63c42) into main (e903886) will decrease coverage by 4.30%.
Report is 1 commits behind head on main.
The diff coverage is 27.90%.

@@            Coverage Diff             @@
##             main     #232      +/-   ##
==========================================
- Coverage   88.17%   83.88%   -4.30%     
==========================================
  Files          18       19       +1     
  Lines        1201     1272      +71     
  Branches      193      205      +12     
==========================================
+ Hits         1059     1067       +8     
- Misses         93      153      +60     
- Partials       49       52       +3     

Files Changed	Coverage Δ
...rc/migration/TLC_globalUnlockScheduleMigration.sol	0.00% <0.00%> (ø)
...src/components/ERC20VestableVotesUpgradeable.1.sol	91.59% <87.50%> (-2.95%)	⬇️
contracts/src/OperatorsRegistry.1.sol	89.31% <100.00%> (+0.07%)	⬆️
contracts/src/RedeemManager.1.sol	89.26% <100.00%> (+0.07%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[cebidhem]

Relevant fixes from Spearbit audit have been implemented.

2 CI tests are failing:

• lint
• check deploy scripts

Both are ok locally, but I don't want to add another commit to fix those now that the Audit period is over. This will need to be fixed after this PR.

In the meantime, LGTM 🚀