Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TLC code #238

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove TLC code #238

wants to merge 1 commit into from

Conversation

0xvv
Copy link
Contributor

@0xvv 0xvv commented Oct 23, 2023

Description

The TLC token will be developed in a dedicated repository from now on.

Notice

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you assigned this PR to yourself?
  • Have you added at least 1 reviewer?

Pull Request Type

  • 💫 New Feature (Breaking Change)
  • 💫 New Feature (Non-breaking Change)
  • 🛠️ Bug fix (Non-breaking Change: Fixes an issue)
  • 🕹️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)

Breaking changes (if applicable)

Removed TLC code

@0xvv 0xvv self-assigned this Oct 23, 2023
Signed-off-by: 0xvv <[email protected]>
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #238 (38f9f0c) into main (d8b7e42) will decrease coverage by 0.53%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #238      +/-   ##
==========================================
- Coverage   83.88%   83.36%   -0.53%     
==========================================
  Files          19       17       -2     
  Lines        1272     1148     -124     
  Branches      205      176      -29     
==========================================
- Hits         1067      957     -110     
+ Misses        153      145       -8     
+ Partials       52       46       -6     

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@iamsahu iamsahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The files related to deployment of TLC are still present in this repo. I think it should be moved to the new TLC repo so that everything related to it are present in one place and not spread across multiple repos.

@0xvv
Copy link
Contributor Author

0xvv commented Oct 24, 2023

We discussed with Mehdi leaving yarn behind and having a fully foundry based repo, that means the deployment stack of the TLC repo will be different and i think it makes more sense leaving the existing here since it was deployed using the scripts in this repo and will not necessarily be compatible with the future TLC deployment stack which would cause confusion long term imo.

Note that the existing deployment artifacts are duplicated in the TLC repos for ease of access, simply not the deployments scripts and their outputs.

The same way i did not remove TLC related entries from the CHANGELOG of this repository, which i think makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants