Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocol metrics with deployment scripts #265

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iamsahu
Copy link
Contributor

@iamsahu iamsahu commented May 3, 2024

Description

An upgradeable protocol metrics contract for getting exchange rate

Notice

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you assigned this PR to yourself?
  • Have you added at least 1 reviewer?
  • Have you updated the official documentation?
  • Have you added sufficient documentation in your code?
  • Have you added relevant tests to the official test suite?

Pull Request Type

  • 💫 New Feature (Breaking Change)
  • 💫 New Feature (Non-breaking Change)
  • 🛠️ Bug fix (Non-breaking Change: Fixes an issue)
  • 🕹️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)

Testing

  • Have you tested this code with the official test suite?
  • Have you tested this code manually?

@iamsahu iamsahu self-assigned this May 3, 2024
@iamsahu iamsahu requested a review from mischat May 3, 2024 12:29
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.57%. Comparing base (feb1c7d) to head (07c06ad).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #265      +/-   ##
==========================================
+ Coverage   94.46%   94.57%   +0.11%     
==========================================
  Files          74       74              
  Lines        1751     1751              
  Branches      246      246              
==========================================
+ Hits         1654     1656       +2     
+ Misses         41       39       -2     
  Partials       56       56              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant