Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added blacklist check for recipient during redeemRequest #267

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

iamsahu
Copy link
Contributor

@iamsahu iamsahu commented Jun 6, 2024

Description

Added a check to ensure that black listed address can't be added as a recipient for redemption request

Notice

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you assigned this PR to yourself?
  • Have you added at least 1 reviewer?
  • Have you updated the official documentation?
  • Have you added sufficient documentation in your code?
  • Have you added relevant tests to the official test suite?

Pull Request Type

  • 💫 New Feature (Breaking Change)
  • 💫 New Feature (Non-breaking Change)
  • 🛠️ Bug fix (Non-breaking Change: Fixes an issue)
  • 🕹️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)

Testing

  • Have you tested this code with the official test suite?
  • Have you tested this code manually?

@iamsahu iamsahu requested a review from cebidhem as a code owner June 6, 2024 16:39
@iamsahu iamsahu self-assigned this Jun 6, 2024
@iamsahu iamsahu requested a review from mischat June 6, 2024 16:39
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.48%. Comparing base (3e32b97) to head (07cfbe8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #267   +/-   ##
=======================================
  Coverage   94.47%   94.48%           
=======================================
  Files          75       75           
  Lines        1775     1778    +3     
  Branches      250      251    +1     
=======================================
+ Hits         1677     1680    +3     
  Misses         41       41           
  Partials       57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mischat mischat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks

@iamsahu iamsahu merged commit cb31185 into main Jun 7, 2024
20 checks passed
@iamsahu iamsahu deleted the fix/certora-H2-fix-extension branch June 7, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants