Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added version view function #270

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Added version view function #270

wants to merge 3 commits into from

Conversation

iamsahu
Copy link
Contributor

@iamsahu iamsahu commented Jul 2, 2024

Description

Currently there is no way to understand which version of the contract is deployed. We introduce a new interface IVersionV1 which is implemented by all the major contracts. The interface exposes a method which returns the hard coded version of the contract.

Notice

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you assigned this PR to yourself?
  • Have you added at least 1 reviewer?
  • Have you updated the official documentation?
  • Have you added sufficient documentation in your code?
  • Have you added relevant tests to the official test suite?

Pull Request Type

  • 💫 New Feature (Breaking Change)
  • 💫 New Feature (Non-breaking Change)
  • 🛠️ Bug fix (Non-breaking Change: Fixes an issue)
  • 🕹️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)

Testing

  • Have you tested this code with the official test suite?
  • Have you tested this code manually?

@iamsahu iamsahu self-assigned this Jul 2, 2024
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.31%. Comparing base (a8aa8f8) to head (00cf2b6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #270      +/-   ##
==========================================
+ Coverage   94.54%   95.31%   +0.77%     
==========================================
  Files          75       74       -1     
  Lines        1777     1730      -47     
  Branches      251      234      -17     
==========================================
- Hits         1680     1649      -31     
+ Misses         40       26      -14     
+ Partials       57       55       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mischat mischat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, we should get it in, let's put the correct version on it, and then we can merge it into main. v1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants