feat: multi-database configurations #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Documentation preview will be available shortly at https://jolt-org.github.io/advanced-alchemy-docs-preview/151 |
Signed-off-by: Cody Fincher <[email protected]>
* feat: services accept BaseModels and Structs * fix: adds tests for converting struct and basemodel classes * fix: correct configuration * feat: tweak to_dict
* feat: services accept BaseModels and Structs * fix: adds tests for converting struct and basemodel classes * fix: correct configuration * feat: tweak to_dict * feat: add a `to_schema` parameter to services * chore: linting * fix: type checking * feat: assert model --------- Signed-off-by: Cody Fincher <[email protected]>
Signed-off-by: Cody Fincher <[email protected]>
* feat: improved typing * chore: bump version * feat: i think this is better for linters * chore: revert changes * feat: use type guard * feat: type ignore * feat: precommit hook * fix: updated dict type signature * chore: linting fixes * chore: limit concurrency per branch * feat: lint fix * fix: add missing returns * fix: don't assign an extra variable * feat: allow filters in single row queries (#222) * wip * feat: allow single row operations to filter * fix: remove deprecation test
- Reverts the previous `to_schema` implementation in the service layer. This will need to be rethought as it requires too many overloads to any customized service function. - Ensures that the filter values for `upsert_many` is a unique list. This is useful when you are merging a large amount of objects on a foreign key. The lookup will only contain a single unique entry for each key instead of one for each row. - Adds a `schema_to_dict` method to convert incoming Pydantic or Msgspec models to dictionaries - Adds additional type guard helpers to check for a field in a dictionary, Struct, or BaseModel
* feat: additional tests and helper methods * feat: re-use functions * feat: simplify logic further
Signed-off-by: Cody Fincher <[email protected]>
provinzkraut
approved these changes
Jun 30, 2024
There was a problem hiding this comment.
Looks good!
One idea though: Since the session scope key is only used internally, how about, instead requiring the user to define one for multiple configs, we simply keep track of all the ones we have created (e.g. via a class var on the base config) and then ensure they are unique? That would make it a bit more "it just works"
advanced_alchemy/extensions/litestar/plugins/init/config/asyncio.py
Outdated
Show resolved
Hide resolved
* feat(cli): Adds drop-all option to the litestar cli * fix(mypy): CI failure * tests(cli): Add tests for drop-all * chore: remove unnecessary import * feat: updated tests * fix: 3.8 and 3.9 support * chore: revert later * revert: "chore: revert later" This reverts commit 4091abd. * chore: 3.8/3.9 support * chore: add eval type check * chore: fix lint * feat: updated linting --------- Co-authored-by: Alc-Alc <alc@localhost> Co-authored-by: Cody Fincher <[email protected]>
Signed-off-by: Cody Fincher <[email protected]>
Alc-Alc
approved these changes
Jul 1, 2024
Alc-Alc
approved these changes
Jul 1, 2024
|
|
Documentation preview will be available shortly at https://litestar-org.github.io/advanced-alchemy-docs-preview/151 |
cofin
added a commit
that referenced
this pull request
Jul 1, 2024
* feat: multi-database configurations --------- Signed-off-by: Cody Fincher <[email protected]> Co-authored-by: Alc-Alc <[email protected]> Co-authored-by: Alc-Alc <alc@localhost>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the Litestar plugin to be configured with multiple databases