refactor: deprecate CORSMiddleware from public interface. #3404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/middleware
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3404 +/- ##
=======================================
Coverage 98.27% 98.28%
=======================================
Files 323 324 +1
Lines 14766 14774 +8
Branches 2345 2346 +1
=======================================
+ Hits 14512 14520 +8
Misses 116 116
Partials 138 138 ☔ View full report in Codecov by Sentry. |
provinzkraut
approved these changes
Apr 18, 2024
peterschutt
force-pushed
the
cors-mounted-apps
branch
from
080ae1a
to
a30484d
Compare
It is used internally, its use is hardcoded and it doesn't work similar to other middleware when added to layers. Should be implementation detail IMO. Closes #3403
peterschutt
force-pushed
the
deprecate-cors-middleware
branch
from
fa81860
to
dd206e8
Compare
|
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3404 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is used internally, its use is hardcoded and it doesn't work similar to other middleware when added to layers.
Should be implementation detail IMO.
Closes #3403
Description
Closes