-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: template exception #3561
base: main
Are you sure you want to change the base?
Conversation
mkdir parents True
Co-authored-by: Jacob Coffee <[email protected]>
…itestar-org#3527) * Convert controllers to routers on registration
* chore(docs): updated example for flash messages * chore: remove redundant store config
Co-authored-by: Jacob Coffee <[email protected]> rm underscore fix/already-async .
Co-authored-by: euri10 <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3561 +/- ##
==========================================
- Coverage 98.25% 98.24% -0.02%
==========================================
Files 328 328
Lines 14870 14868 -2
Branches 2366 2364 -2
==========================================
- Hits 14611 14607 -4
- Misses 117 119 +2
Partials 142 142 ☔ View full report in Codecov by Sentry. |
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3561 |
@JacobCoffee how could I ask for a review? I can not click and change "Reviewers" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @Murtagy!
I'm afraid this will have to wait until 3.0, as it is a breaking change because it changes the exception type, which some users might rely on.
If you want, you can retarget this at the v3.0 branch
What is the exception that users could already handle? |
Description
Added a wrapper around exceptions coming from templates.
The exceptions can be rather cryptic, so having a little more context around them is helpful.
So the core benefit of this PR is the change of
into
Which now points to exact template location. Woohoo!
I did not add any tests for these 🤷