Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#3554): correct module_to_os_path to return directory paths #3565

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

supercoder-dev
Copy link

To resolve the issue, we need to update the module_to_os_path function to check if the found path is a file. If it is, we should return the parent directory instead. This can be done by using Path(src.origin).parent if src.origin is a file.

@supercoder-dev supercoder-dev requested review from a team as code owners June 12, 2024 11:05
@provinzkraut provinzkraut changed the title Issue 3554 resolved fix: #3554 Jun 13, 2024
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.28%. Comparing base (6eb4583) to head (54899a8).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3565   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files         328      328           
  Lines       14859    14860    +1     
  Branches     2362     2362           
=======================================
+ Hits        14604    14605    +1     
  Misses        116      116           
  Partials      139      139           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JacobCoffee JacobCoffee changed the title fix: #3554 fix(#3554): correct module_to_os_path to return directory paths Jun 13, 2024
@JacobCoffee JacobCoffee changed the title fix(#3554): correct module_to_os_path to return directory paths fix(#3554): correct module_to_os_path to return directory paths Jun 13, 2024
@JacobCoffee JacobCoffee changed the title fix(#3554): correct module_to_os_path to return directory paths fix(#3554): correct module_to_os_path to return directory paths Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant