Update to symfony 5.3

composer.json

@@ -4,12 +4,14 @@
     "type": "library",
     "require": {
         "php": "^7.2",
-        "symfony/workflow": "^4.4",
+        "symfony/workflow": "^5.3",
         "roave/security-advisories": "dev-master",
         "doctrine/orm": "^2.5",
-        "symfony/console": "^4.4",
-        "doctrine/cache": "^1.6"
+        "symfony/console": "^5.3"
     },
+    "repositories": [
+        {"type": "vcs", "url": "https://github.com/etoa/Silex"}
+    ],
     "license": "MIT",
     "authors": [
         {
@@ -30,7 +32,7 @@
     "require-dev": {
         "phpunit/phpunit": "^8.0",
         "friendsofphp/php-cs-fixer": "^2.0",
-        "silex/silex": "^2.0",
+        "silex/silex": "dev-t/symfony-53",
         "phpstan/phpstan": "^0.12",
         "phpstan/phpstan-strict-rules": "^0.12",
         "phpstan/phpstan-phpunit": "^0.12",

phpstan.neon

@@ -17,6 +17,4 @@ parameters:
         - '#Dynamic call to static method PHPUnit\\Framework\\TestCase#'
         - '#assertInstanceOf\(\) expects class-string\<object\>\, string given#'
         - '#ProgressHandler\:\:handle\(\) expects callable#'
-        - '#Method Symfony\\Contracts\\EventDispatcher\\EventDispatcherInterface::dispatch\(\) invoked with 2 parameters, 1 required.#'
         - '#Method LittleCubicleGames\\Quests\\Progress\\ProgressHandler::handle\(\) has parameter \$event with no typehint specified.#'
-        - '#Doctrine\\Common\\Cache\\ArrayCache#'

src/Guard/IsCompletedListener.php

@@ -31,7 +31,7 @@ public function validate(GuardEvent $event): void
     }
 
     /**
-     * @return string[]
+     * @return array<string, string>
      */
     public static function getSubscribedEvents(): array
     {

src/Helper/ArrayCache.php

@@ -0,0 +1,44 @@
+<?php declare(strict_types=1);
+
+namespace LittleCubicleGames\Quests\Helper;
+
+use Doctrine\Common\Cache\Cache;
+
+class ArrayCache implements Cache
+{
+    /** @var array<mixed, mixed> */
+    private $cache = [];
+
+    public function fetch($id)
+    {
+        return $this->cache[$id] ?? null;
+    }
+
+    public function contains($id)
+    {
+        return isset($this->cache[$id]);
+    }
+
+    public function save($id, $data, $lifeTime = 0)
+    {
+        $this->cache[$id] = $data;
+
+        return true;
+    }
+
+    public function delete($id)
+    {
+        if ($this->contains($id)) {
+            unset($this->cache[$id]);
+
+            return true;
+        }
+
+        return false;
+    }
+
+    public function getStats()
+    {
+        return null;
+    }
+}

src/ServiceProvider.php

@@ -2,7 +2,7 @@
 
 namespace LittleCubicleGames\Quests;
 
-use Doctrine\Common\Cache\ArrayCache;
+use Doctrine\Common\Cache\Cache;
 use LittleCubicleGames\Quests\Command\ValidationCommand;
 use LittleCubicleGames\Quests\Definition\Quest\QuestBuilder;
 use LittleCubicleGames\Quests\Definition\Registry\RandomRegistry;
@@ -11,6 +11,7 @@
 use LittleCubicleGames\Quests\Definition\Task\TaskBuilder;
 use LittleCubicleGames\Quests\Guard\IsCompletedListener;
 use LittleCubicleGames\Quests\Guard\TriggerValidator;
+use LittleCubicleGames\Quests\Helper\ArrayCache;
 use LittleCubicleGames\Quests\Initialization\NextQuestListener;
 use LittleCubicleGames\Quests\Initialization\QuestInitializer;
 use LittleCubicleGames\Quests\Initialization\QuestStarter;
@@ -31,7 +32,6 @@
 use Silex\Api\EventListenerProviderInterface;
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;
 use Symfony\Component\Workflow\MarkingStore\MethodMarkingStore;
-use Symfony\Component\Workflow\MarkingStore\SingleStateMarkingStore;
 use Symfony\Component\Workflow\Workflow;
 
 class ServiceProvider implements ServiceProviderInterface, EventListenerProviderInterface
@@ -76,7 +76,7 @@ public function register(Container $pimple): void
             return new SlotBuilder();
         };
 
-        $pimple['cubicle.quests.definition.cache'] = function (): ArrayCache {
+        $pimple['cubicle.quests.definition.cache'] = function (): Cache {
             return new ArrayCache();
         };
 

tests/Integration/WorkflowTest.php

@@ -112,7 +112,7 @@ public function testProgress(): void
         $event = new Event($eventQuest, new Marking(), new Transition(QuestDefinitionInterface::TRANSITION_REJECT, '', ''));
         for ($i = 0; $i < 11; $i++) {
             $this->assertSame(QuestDefinitionInterface::STATE_IN_PROGRESS, $quest->getState());
-            $this->app['dispatcher']->dispatch($eventName, $event);
+            $this->app['dispatcher']->dispatch($event, $eventName);
         }
 
         $this->assertSame(QuestDefinitionInterface::STATE_FINISHED, $quest->getState());