This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
[[ Bug 22211 ]] Remove unnecessary 'unlock cursor' in ideMouseMove #2092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runrevmark
changed the title
|
I suggest updating the title of the commit message to: And then have a commit message body: |
runrevmark
suggested changes
Apr 27, 2020
| @@ -0,0 +1 @@ | |||
| # Ensure lock cursor does not break when the pointer tool is selected | |||
There was a problem hiding this comment.
I suggest
# Fix IDE interference with locking the cursor when pointer tool is selected
This patch removes a seemingly unnecessary `unlock cursor` in the IDE's mouseMove event handler (`ideMouseMove`). The IDE intercepts mouseMove so that it can update the resize cursor used when the mouse is over the relevant selection handlers. It does this by locking the cursor in this case and then changing the cursor appropriately; unlocking the cursor when there is a selected object and the mouse is not over a selection handle. Previously it would also unlock the cursor if pointer tool was in effect and there was no selected object which (because the handler is executed in time after any user handlers) would undo any user use of `lock cursor`.
livecodepanos
force-pushed
the
bugfix-22211
branch
from
6523813
to
2f9bb4a
Compare
|
Setting the to WIP for further investigation, as this patch introduces this regression: Recipe: Move from a selection handle horizontally left out of the selected objects rect. Expected result: The cursor to switch from the resizing cursor to the usual one |
BerndN
added a commit
to BerndN/livecode-ide
that referenced
this pull request
May 6, 2020
This patch removes a seemingly unnecessary `unlock cursor` in the IDE's mouseMove event handler (`ideMouseMove`). The IDE intercepts mouseMove so that it can update the resize cursor used when the mouse is over the relevant selection handlers. It does this by locking the cursor in this case and then changing the cursor appropriately; unlocking the cursor when there is a selected object and the mouse is not over a selection handle. Previously it would also unlock the cursor if pointer tool was in effect and there was no selected object which (because the handler is executed in time after any user handlers) would undo any user use of `lock cursor`. This fixes bug 22211 and bug 18428 and avoids the problems of a fix for these in livecode#2092
|
Replaced by #2132 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes a seemingly unnecessary
unlock cursorin the IDE'smouseMove event handler (
ideMouseMove).The IDE intercepts mouseMove so that it can update the resize cursor
used when the mouse is over the relevant selection handlers. It does this
by locking the cursor in this case and then changing the cursor
appropriately; unlocking the cursor when there is a selected object and
the mouse is not over a selection handle.
Previously it would also unlock the cursor if pointer tool was in effect and
there was no selected object which (because the handler is executed in
time after any user handlers) would undo any user use of
lock cursor.Closes https://quality.livecode.com/show_bug.cgi?id=22211