This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
[Bug 22555] Keep compile errors in SE w/o LiveError on #2117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If LiveError is off compile errors are not flagged if one clicks in field "script" or any other action in SE. Bug 22555
|
I don't understand this. If the code in both branches of the conditional is the same, why duplicate it? Why not just get rid of the 'if LiveErrors then' test? |
|
This was the place I found where it did what I wanted. I am not even sure it is the best place to fix this. I wanted to change as little as possible as far as the basic structure is concerned and make it easy for the reviewer to review this patch. Maybe @montegoulding could shed some light on this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If LiveError is off compile errors are not flagged if one clicks in field "script" or any other action in SE.
Bug 22555