Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark all LPMS errors as non-retryable? #1774

Closed
yondonfu opened this issue Feb 22, 2021 · 1 comment · Fixed by #1823
Closed

Mark all LPMS errors as non-retryable? #1774

yondonfu opened this issue Feb 22, 2021 · 1 comment · Fixed by #1823
Assignees

Comments

@yondonfu
Copy link
Member

yondonfu commented Feb 22, 2021

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

There are other LPMS transcode errors not in the exported LPMSErrors map that are not currently marked as non-retryable. As a result, when B encounters these errors from O it'll retry the segment even though the segments cannot be transcoded.

Ex.

Perhaps it'd make sense to just treat all errors that come from LPMS as non-retryable instead of trying to enumerate all of them. This may be too extreme though - should think about whether there are cases where the errors from LPMS should be retryable.

@yondonfu
Copy link
Member Author

We should keep in mind that there are certain LPMS errors that we should probably retry on. For example, if an OOM error is returned, that segment could still be transcoded by another node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants