Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: Update NonRetryable errors to latest LPMS #1823

Merged
merged 4 commits into from
Apr 8, 2021
Merged

Conversation

jailuthra
Copy link
Contributor

@jailuthra jailuthra commented Apr 1, 2021

What does this pull request do? Explain your changes. (required)

Update non-retriable error list to include more errors

Specific updates (required)

See commit history

How did you test each of these updates (required)

Manually tested desired behaviour occurs for newly added errors in the list like "Audio Only Segment".

W0406 05:11:44.990130 2605883 broadcast.go:447] Not retrying current segment nonce=9309343988758959823 seqNo=1 due to non-retryable error err=TranscoderInvalidVideo
E0406 05:11:44.990153 2605883 mediaserver.go:874] http push error processing segment url=http://127.0.0.1:8936/live/test/1.ts manifestID=test err=TranscoderInvalidVideo

Does this pull request close any open issues?

Fixes #1774

Checklist:

jailuthra added a commit that referenced this pull request Apr 5, 2021
@jailuthra jailuthra marked this pull request as ready for review April 5, 2021 23:48
@jailuthra jailuthra changed the title server: update non-retriable-error list server: Update NonRetryable errors to latest LPMS Apr 5, 2021
Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after resolving conflicts.

server/broadcast.go Show resolved Hide resolved
Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jailuthra jailuthra merged commit b909883 into master Apr 8, 2021
jailuthra added a commit that referenced this pull request Apr 8, 2021
@jailuthra jailuthra deleted the jai/nonretriable branch April 8, 2021 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mark all LPMS errors as non-retryable?
2 participants