Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It/http2dialtimeout #1645

Merged
merged 2 commits into from
Oct 23, 2020
Merged

It/http2dialtimeout #1645

merged 2 commits into from
Oct 23, 2020

Conversation

darkdarkdragon
Copy link
Contributor

What does this pull request do? Explain your changes. (required)
Adds timeout to HTTP2 dial phase

Specific updates (required)

How did you test each of these updates (required)

Does this pull request close any open issues?

Checklist:

  • README and other documentation updated
  • Node runs in OSX and devenv
  • All tests in ./test.sh pass

yondonfu
yondonfu reviewed Oct 23, 2020
View reviewed changes
Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but can we move the commits unrelated to this fix to #1644 and merge them in that PR?

yondonfu
yondonfu approved these changes Oct 23, 2020
View reviewed changes
Copy link
Member

@yondonfu yondonfu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

Spoke with @iameli and looks like we'd like to get this fix for the broadcaster stuck issue merged into master before the weekend so I dropped the memory leak commit which can be merged via #1644.

@yondonfu yondonfu merged commit 506d5c1 into master Oct 23, 2020
@yondonfu yondonfu deleted the it/http2dialtimeout branch October 23, 2020 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yondonfu yondonfu yondonfu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@darkdarkdragon @yondonfu