eth: max gas price #1727
Merged
eth: max gas price #1727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyriediculous
force-pushed
the
nv/max-gasprice
branch
from
1e2cc1c
to
776a65a
Compare
kyriediculous
force-pushed
the
nv/max-gasprice
branch
from
28df87e
to
217d4a3
Compare
yondonfu
requested changes
Mar 3, 2021
yondonfu
requested changes
Mar 4, 2021
yondonfu
requested changes
Mar 4, 2021
yondonfu
requested changes
Mar 5, 2021
|
Should have addressed remaining comments, added max gas price to node stats in CLI, improved error logging. |
yondonfu
reviewed
Mar 8, 2021
kyriediculous
force-pushed
the
nv/max-gasprice
branch
from
1bc1b8b
to
d05dd4d
Compare
|
Rebased and tested on rinkeby, pending green CI |
kyriediculous
force-pushed
the
nv/max-gasprice
branch
from
d05dd4d
to
e4f504b
Compare
|
Finally got CI to pass , kept running into issues with unrelated tests in the server repo (SubmitSegment). |
yondonfu
reviewed
Mar 10, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Changes
-gasPriceflag to-maxGasPriceand allows users to set a max gas price to pay for transactions.Specific updates (required)
Changes
-gasPriceflag to be-maxGasPriceinstead. Removes-gasLimitflag (seems superflious).Implements
SuggestGasPricethat checks for the max gas price when set ,MaxGasPriceandSetMaxGasPriceonBackend.Changes CLI server API endpoings
/gasPriceand/setGasPriceto/maxGasPriceand/setMaxGasPriceSince the gasLimit flag is removed and the
gasPriceflag repurposedLivepeerEthClient.GasInfoandLivepeerEthClient.SetGasInfoare no longer needed and removed.Moved unlocking the Eth account into the
LivepeerEthClientconstructor and removedLivepeerEthClient.Setupas it now only unlocks the account after removingLivepeerEthClient.SetGasInfoUpdates the CLI to allow for setting a max gas price
How did you test each of these updates (required)
Does this pull request close any open issues?
Fixes #1671
Checklist:
./test.shpass