server: transcode auth webhook #1731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkdarkdragon
suggested changes
Jan 8, 2021
| @@ -302,6 +309,34 @@ func verifyOrchestratorReq(orch Orchestrator, addr ethcommon.Address, sig []byte | |||
| return orch.CheckCapacity("") | |||
| } | |||
|
|
|||
| // authenticateBroadcaster returns an error if authentication fails | |||
| func authenticateBroadcaster(id string) error { | |||
| if AuthWebhookURL == "" { | |||
There was a problem hiding this comment.
AuthWebhookURL is set only for Broadcaster node
There was a problem hiding this comment.
fixed in 9ce9e44
darkdarkdragon
suggested changes
Jan 8, 2021
|
|
||
| Webhooks can authenticate streams supported by the RTMP and HTTP push ingest protocols. See the [ingest documentation](ingest.md) for details on how to use these protocols. | ||
| The webhook server should respond with HTTP status code `200` in order to authenticate / authorize the stream. A response with a HTTP status code other than `200` will cause the Livepeer node to disconnect the stream. |
There was a problem hiding this comment.
This says that code should be strictly 200 for success, but actual code checks for whole 2XX range. Should we make them match?
There was a problem hiding this comment.
fixed in 4090a12
yondonfu
requested changes
Feb 10, 2021
kyriediculous
force-pushed
the
nv/transcode-auth
branch
2 times, most recently
from
2212d19
to
80fc877
Compare
kyriediculous
force-pushed
the
nv/transcode-auth
branch
from
80fc877
to
514e94e
Compare
kyriediculous
force-pushed
the
nv/transcode-auth
branch
from
3202e6d
to
2364519
Compare
darkdarkdragon
approved these changes
Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Allows Orchestrators to specify an
-authWebhookUrlto authenticate broadcasters upon discovery (GetOrchestatorInfo).Specific updates (required)
created an
authenticateBroadcaster()function inserver/rpc.gothis will no-op if no-authWebhookUrlis specifiedAdd a call to
authenticateBroadcaster()when callinggetOrchestrator()inserver/rpc.goAdded unit tests for this new behaviour for
getOrchestrator()using thehttptestpackage which spins up a one-off http server which we specify asserver.AuthWebhookUrlUpdated documentation on auth webhooks in
docHow did you test each of these updates (required)
Added unit/integration tests
Does this pull request close any open issues?
Fixes #1569
Checklist:
./test.shpass