Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count bytes of video data received/sent by broadcaster per stream #1754

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

darkdarkdragon
Copy link
Contributor

What does this pull request do? Explain your changes. (required)
Count bytes of video data received/sent by broadcaster per stream
and expose that in /status endpoint.
These allows to calculate ingest rate.

Specific updates (required)

  • Added two fields to the rtmpConnection structure and exposed them in the /status endpoint

How did you test each of these updates (required)
unit test

Does this pull request close any open issues?
Fixes #1752

Checklist:

  • README and other documentation updated
  • Node runs in OSX and devenv
  • All tests in ./test.sh pass

Copy link
Contributor

@jailuthra jailuthra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

and expose that in /status endpoint.
These allows to calculate ingest rate.
@darkdarkdragon darkdarkdragon merged commit e2d22f8 into master Feb 3, 2021
@darkdarkdragon darkdarkdragon deleted the it/bytes-counter branch February 3, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose byte count for a stream
2 participants