Capture and log error on webserver crash #1759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @yondonfu, following up from discord. If you want me to test this branch out a bit more that's okay, just lmk. |
|
Wooooo thanks @yondonfu! Hoping to see the livepeer team soon once lockdown ends |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
I wrote up some more info on this problem in #1758.
We're running into some issues in
v0.5.14with the webserver silently crashing, and figured having the underlying error logged would help a lot with usability.Specific updates (required)
glog.Error()How did you test each of these updates (required)
I didn't test these, the change is small enough I assume it should work alright.
Up to the livepeer devs if they think this is reasonable, or if I should do some more testing myself.
Here's an example 20 lines down where we use this same pattern: https://github.com/livepeer/go-livepeer/blob/master/server/webserver.go#L92-L93
Does this pull request close any open issues?
#1758
Checklist:
./test.shpassI skipped over these as well^, am so used to running livepeer in alpine linux I'll admit I'm not too versed manually building for this binary for OSX.
I can follow through with these steps if we'd like, just let me know!
Didn't see any relevant documentation that we'd want to update for this.