Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install_ffmpeg: download pre-configured nasm #1773

Merged
merged 2 commits into from
Feb 22, 2021
Merged

Conversation

iameli
Copy link
Member

@iameli iameli commented Feb 22, 2021

the autoconf step was failing on windows. this should sidestep that.
Added sha256sum so we're not just downloading some random archive.

the autoconf step was failing on windows. this should sidestep that.
sha256sum so we're not just downloading some random archive.
@iameli iameli requested a review from yondonfu February 22, 2021 21:22
Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yondonfu yondonfu merged commit fb2c47b into master Feb 22, 2021
@yondonfu yondonfu deleted the eli/nasm-no-autogen branch February 22, 2021 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants