Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LB transcoder race condition around session-cleanup #1775

Merged
merged 3 commits into from
Feb 25, 2021
Merged

Conversation

jailuthra
Copy link
Contributor

@jailuthra jailuthra commented Feb 24, 2021

What does this pull request do? Explain your changes. (required)

Ensure that no segments are left hanging since we increased the LB channel size in 882ed38

Specific updates (required)

How did you test each of these updates (required)

  • Run the test case in 415c1c0 to reproduce hanging behaviour
  • Run the test case again after the fix to verify hanging behaviour does not happen anymore

Does this pull request close any open issues?

Fixes #1750

Checklist:

  • README and other documentation updated
  • Node runs in OSX and devenv
  • All tests in ./test.sh pass

Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Just a few minor comments relating to the tests.

core/lb_test.go Outdated Show resolved Hide resolved
core/lb_test.go Outdated Show resolved Hide resolved
core/lb_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@kyriediculous kyriediculous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me pending Yondon's comments 👍

Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after squashing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants