cmd/livepeer_bench: live mode, better stats #1778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yondonfu
reviewed
Mar 1, 2021
| {"Concurrent Sessions", fmt.Sprintf("%v", *concurrentSessions)}, | ||
| {"Total Segs Transcoded", fmt.Sprintf("%v", segCount)}, | ||
| {"Real-Time Segs Transcoded", fmt.Sprintf("%v", realTimeSegCount)}, | ||
| {"* Real-Time Segs Ratio *", fmt.Sprintf("%0.4v", float64(realTimeSegCount)/float64(segCount))}, |
There was a problem hiding this comment.
Curious why asterisks are added here? Anything particularly special about this stat relative to the other ones?
There was a problem hiding this comment.
Wanted to highlight this and Real-Time Duration Ratio in some manner - as a user I would personally be most interested in quickly eyeballing these two ratios. WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Add option to simulate live-mode in the benchmarking tool. Also, clean up the output statistics to show real-time segment ratio and stream duration ratio.
Specific updates (required)
How did you test each of these updates (required)
Manual testing with
./livepeer_bench -in ~/Videos/bbb/source.m3u8 -outPrefix /tmp/out -nvidia 0 -concurrentSessions 20 -transcodingOptions cmd/livepeer_bench/transcodingOptions.json -segs 20Does this pull request close any open issues?
Fixes #1699
Checklist:
./test.shpass