Fix for multi-seg-in-flight #1782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jailuthra can you take a look? I think in case of call to |
darkdarkdragon
force-pushed
the
it/potential-problem
branch
2 times, most recently
from
4201123
to
6d7cd2b
Compare
'SegsInFlight' is lost in case of session refresh
of session refresh
darkdarkdragon
force-pushed
the
it/potential-problem
branch
from
6d7cd2b
to
1b59591
Compare
darkdarkdragon
changed the title
darkdarkdragon
requested review from
yondonfu and
jailuthra
and removed request for
jailuthra
|
@jailuthra sorry I saw your comment about Changelog right after I've pressed 'merge' button |
jailuthra
added a commit
that referenced
this pull request
Mar 24, 2021
jailuthra
added a commit
that referenced
this pull request
Mar 25, 2021
jailuthra
added a commit
that referenced
this pull request
Mar 25, 2021
jailuthra
added a commit
that referenced
this pull request
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Fixes case where data in
SegsInFlightarray gets lost after session refreshSpecific updates (required)
lastSessfield.How did you test each of these updates (required)
Unit test.
Does this pull request close any open issues?
Checklist:
./test.shpass