Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/lb: use SessionID as map index #1784

Merged
merged 1 commit into from
Mar 4, 2021
Merged

core/lb: use SessionID as map index #1784

merged 1 commit into from
Mar 4, 2021

Conversation

jailuthra
Copy link
Contributor

What does this pull request do? Explain your changes. (required)

Use SessionID instead of ManifestID to index the loadbalancer sessions.

Specific updates (required)

  • a3862f1 Use SessionID as map index

How did you test each of these updates (required)

  • Run the lb unit tests
  • Verify that SessionId is now used within the log lines on a local O
I0305 01:40:55.807153   31849 orchestrator.go:474] Submitted segment to transcode loop manifestID=movmovv sessionID=a7a6b2b9 seqNo=1
I0305 01:40:55.807386   31849 lb.go:54] LB: Using existing transcode session for a7a6b2b9_0

Does this pull request close any open issues?

Fixes #1748

Checklist:

  • README and other documentation updated
  • Node runs in OSX and devenv
  • All tests in ./test.sh pass

Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@jailuthra jailuthra merged commit f4a2efb into master Mar 4, 2021
@yondonfu yondonfu deleted the jai/lbsessid branch March 5, 2021 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lb: LoadBalancingTranscoder should use AuthToken.SessionId instead of ManifestID to index into sessions
2 participants