Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: fully-static build, bump to go1.15 #1785

Merged
merged 2 commits into from
Mar 9, 2021

Conversation

iameli
Copy link
Member

@iameli iameli commented Mar 4, 2021

What does this pull request do? Explain your changes. (required)

  • Bump Windows go build to go1.15
  • Implement a fully-static livepeer.exe file with no more bundled DLLs. And it only took me two years.

How did you test each of these updates (required)
It works!
image

Checked with both GPU and CPU transcoding. I didn't check on-chain mode but presumably anything that's mostly Go code is fine.

@iameli iameli force-pushed the eli/windows-static-finally branch from edb699d to 8349128 Compare March 4, 2021 21:27
@iameli iameli force-pushed the eli/windows-static-finally branch from 3e5b7cb to 871066e Compare March 5, 2021 06:24
@iameli iameli marked this pull request as ready for review March 5, 2021 06:24
@iameli iameli requested review from yondonfu, darkdarkdragon and kyriediculous and removed request for yondonfu March 5, 2021 06:24
Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot! LGTM :shipit:

@iameli iameli merged commit f92c273 into master Mar 9, 2021
@iameli iameli deleted the eli/windows-static-finally branch March 9, 2021 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants