Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install_ffmpeg.sh: add -O2 to gnutls build #1795

Merged
merged 1 commit into from
Mar 12, 2021
Merged

install_ffmpeg.sh: add -O2 to gnutls build #1795

merged 1 commit into from
Mar 12, 2021

Conversation

iameli
Copy link
Member

@iameli iameli commented Mar 12, 2021

Apparently -O2 optimizations change the macros around enough that the Darwin bug doesn't exist anymore

fixes #1788

@iameli iameli requested a review from yondonfu March 12, 2021 19:47
yondonfu
yondonfu approved these changes Mar 12, 2021
View reviewed changes
Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for testing this alternative fix. Not sure what the implications are of changing the optimization level, but I guess we'll see...

@yondonfu yondonfu merged commit 5a5a81b into master Mar 12, 2021
@yondonfu yondonfu deleted the eli/optimized-gnutls branch March 12, 2021 20:00
@yondonfu yondonfu mentioned this pull request Mar 12, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yondonfu yondonfu yondonfu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ci: Darwin builds broken
2 participants
@iameli @yondonfu