discovery: Price checks when caching orchs #1814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed in 4313e32. |
yondonfu
added a commit
that referenced
this pull request
Mar 25, 2021
CHANGELOG_PENDING.md
Outdated
| @@ -19,6 +19,7 @@ | |||
| #### Broadcaster | |||
|
|
|||
| - \#1782 Fix SegsInFlight data-loss on refreshing O sessions (@darkdragon) | |||
| - \#1814 Add price checks when caching orchestrator responses during discovery | |||
There was a problem hiding this comment.
Think it is missing an author here , looks good otherwise !
There was a problem hiding this comment.
Heh realized right after I reviewed your PR 😆
Fixed in c4cefe3
yondonfu
added a commit
that referenced
this pull request
Mar 25, 2021
|
LGTM after squashing 👍 |
kyriediculous
approved these changes
Mar 25, 2021
yondonfu
force-pushed
the
yf/div-by-zero
branch
from
c4cefe3
to
eb110c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Adds price checks when caching orchestrator responses.
Specific updates (required)
See commit history.
How did you test each of these updates (required)
Tested manually and added unit tests.
Does this pull request close any open issues?
N/A
Checklist:
makeruns successfully./test.shpass