discovery,pm,server: Additional checks to avoid nil pointer errors caused by unexpected orchestrator configurations #1818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyriediculous
added a commit
that referenced
this pull request
Mar 26, 2021
kyriediculous
force-pushed
the
nv/nil-checks
branch
from
af682a3
to
b0ef99c
Compare
kyriediculous
changed the title
yondonfu
requested changes
Mar 26, 2021
kyriediculous
force-pushed
the
nv/nil-checks
branch
from
334e281
to
122a5ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Specific updates (required)
validateTicketParams()if the providedticketParamsargument isnilHow did you test each of these updates (required)
Does this pull request close any open issues?
Checklist:
makeruns successfully./test.shpass