server+discovery: Only log errors if request was not cancelled #1837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyriediculous
force-pushed
the
yf/discovery-logging
branch
from
b2f2071
to
b481d15
Compare
yondonfu
commented
May 10, 2021
discovery/discovery.go
Outdated
| @@ -85,8 +86,11 @@ func (o *orchestratorPool) GetOrchestrators(numOrchestrators int, suspender comm | |||
| infoCh <- info | |||
| return | |||
| } | |||
| if err != nil && monitor.Enabled { | |||
| monitor.LogDiscoveryError(err.Error()) | |||
| if err != nil && !errors.Is(err, context.Canceled) && !errors.Is(err, context.DeadlineExceeded) { | |||
There was a problem hiding this comment.
I think we should still log an error if the error wraps a context.DeadlineExceeded as that would indicate a timeout with the O which still feels useful to be aware of as it tells us the O could not respond within the timeout while a context.Cancelled (and empirically, the majority of excessive logging on mainnet for Bs seems to be from context.Cancelled) is always B initiated and doesn't really tell us anything about O's ability to respond. WDYT?
There was a problem hiding this comment.
Fixed and rebased, will approve when CI passes.
kyriediculous
force-pushed
the
yf/discovery-logging
branch
from
b481d15
to
d150b5e
Compare
kyriediculous
approved these changes
May 18, 2021
kyriediculous
force-pushed
the
yf/discovery-logging
branch
from
d150b5e
to
086754e
Compare
|
I just updated the commit message and force pushed (removed "deadline exceeded" bit) , CI already passed before this so I think iit should be okay to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Specific updates (required)
serverpackage instead of concatenating the error message strings. This allows usage oferrors.Is()because it can now unwrap error messages.context.Canceledorcontext.Exceededand only log the error if it doesn'tHow did you test each of these updates (required)
Ran a broadcaster on rinkeby
Does this pull request close any open issues?
Fixes #1846
Checklist:
makeruns successfully./test.shpass