Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pm: increase TicketParams expiration to 10 blocks #1873

Merged
merged 1 commit into from
May 11, 2021
Merged

Conversation

kyriediculous
Copy link
Contributor

What does this pull request do? Explain your changes. (required)
Increase the ticketparams expiration to 10 blocks

Does this pull request close any open issues?
Fixes #1872

Checklist:

Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just missing a changelog entry.

Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment about categorizing the changelog entry, but feel free to address prior to merge.

LGTM

@@ -8,6 +8,7 @@

- \#1848 Use fee cut instead of fee share for user facing language in the CLI (@kyriediculous)
- \#1854 Allow to pass region in the custom s3 storage URL (@darkdarkdragon)
- \#1873 Increase TicketParams expiration to 10 blocks (@kyriediculous)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be under "Orchestrator" since it is an orchestrator implementation detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pm: Increase TicketParams expiration
2 participants