Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi: Remove high card keys for payment metrics #1893

Merged
merged 2 commits into from
May 18, 2021

Conversation

yondonfu
Copy link
Member

@yondonfu yondonfu commented May 18, 2021

What does this pull request do? Explain your changes. (required)

Remove high cardinality keys i.e. recipient/sender and manifestID from payment/ticket metrics. Now, only aggregate payment/ticket metrics are reported and there is no metrics reporting on a per recipient/sender or manifestID basis.

Prometheus doesn't like high cardinality keys/labels so when using Grafana to load Prometheus data a dashboard that uses payment/ticket metrics the dashboard might be really slow to render or may even cause the Grafana app to crash as reported in #1763.

Specific updates (required)

  • Remove high cardinality keys from payment/metrics reporting functions in monitor package
  • Update arguments passed into payment/metrics reporting function calls in other packages

How did you test each of these updates (required)

TBD.

Does this pull request close any open issues?

Fixes #1763

Checklist:

@yondonfu yondonfu requested review from kyriediculous, darkdarkdragon and jailuthra and removed request for kyriediculous May 18, 2021 17:11
@yondonfu yondonfu marked this pull request as ready for review May 18, 2021 17:11
Copy link
Contributor

@darkdarkdragon darkdarkdragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small change

monitor/census.go Show resolved Hide resolved
Copy link
Contributor

@darkdarkdragon darkdarkdragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yondonfu yondonfu force-pushed the yf/slim-down-ticket-metrics branch from 9889725 to 7085b90 Compare May 18, 2021 19:29
@yondonfu yondonfu merged commit 9302416 into master May 18, 2021
@yondonfu yondonfu deleted the yf/slim-down-ticket-metrics branch May 18, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monitoring: Too many data points for "tickets received"
2 participants