eth: tx receipt as embedded value rather than pointer in transaction manager subscriptions #1968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyriediculous
changed the title
kyriediculous
force-pushed
the
nv/reward-nil
branch
from
b446c26
to
c03a7e7
Compare
yondonfu
requested changes
Jul 29, 2021
yondonfu
requested changes
Aug 3, 2021
…manager subscriptions
kyriediculous
force-pushed
the
nv/reward-nil
branch
from
d374718
to
8f861fc
Compare
|
Fixed remaining comments and rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Embed the transaction receipt from the ethereum client as a value rather than a pointer in the
transactionReceiptreturned byTransactionManagersubscriptions.How did you test each of these updates (required)
Does this pull request close any open issues?
Fixes #1964
Checklist:
makeruns successfully./test.shpass