Randomization for unknown sessions at a random frequency #2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yondonfu
force-pushed
the
nv/alt-discovery
branch
from
3f4f06e
to
cbb762c
Compare
yondonfu
force-pushed
the
yf/selection-randomization
branch
from
ceffd80
to
5e32d13
Compare
yondonfu
force-pushed
the
nv/alt-discovery
branch
from
cbb762c
to
1021774
Compare
yondonfu
force-pushed
the
yf/selection-randomization
branch
3 times, most recently
from
9335c1a
to
c3559a4
Compare
yondonfu
force-pushed
the
yf/selection-randomization
branch
2 times, most recently
from
c7f72b4
to
1a35579
Compare
yondonfu
force-pushed
the
yf/selection-randomization
branch
2 times, most recently
from
7911663
to
8fb8409
Compare
jailuthra
force-pushed
the
fast-verification
branch
from
9ba1ab1
to
0c8667e
Compare
randFreq defines frequency to randomly select unknown sessions.
yondonfu
force-pushed
the
yf/selection-randomization
branch
from
de71460
to
04ad3a9
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
This PR adds a randFreq field to MinLSSelector which defines a random frequency at which to randomize the selection of unknown sessions instead of running stake weighted selection when in on-chain mode.
Specific updates (required)
See commit history.
How did you test each of these updates (required)
Added unit tests, but only for simple scenarios as unit testing randomization is a bit tricky so my plan is to also do some manual testing with non-trivial values of randFreq i.e. not 0.0 or 1.0.
Checklist:
makeruns successfully./test.shpass