-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mod,install_ffmpeg: Update lpms and ffmpeg to latest #2027
Conversation
02e6230
to
86f6bfa
Compare
86f6bfa
to
bababe4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking merge for now to get #2028 merged first as a part of a release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few small comments. Let's also rebase off master.
bababe4
to
c3797b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What does this pull request do? Explain your changes. (required)
Update ffmpeg and lpms to latest
Specific updates (required)
See livepeer/FFmpeg#12 and livepeer/FFmpeg#13 for the details on the fixes.
Some other commits related to mpeg7 signatures are also picked in this tree, but they aren't being used in
go-livepeer
as of now.How did you test each of these updates (required)
Does this pull request close any open issues?
Checklist:
make
runs successfully./test.sh
pass