Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mod,install_ffmpeg: Update lpms and ffmpeg to latest #2027

Merged
merged 3 commits into from
Sep 14, 2021

Conversation

jailuthra
Copy link
Contributor

@jailuthra jailuthra commented Sep 10, 2021

What does this pull request do? Explain your changes. (required)

Update ffmpeg and lpms to latest

Specific updates (required)

See livepeer/FFmpeg#12 and livepeer/FFmpeg#13 for the details on the fixes.
Some other commits related to mpeg7 signatures are also picked in this tree, but they aren't being used in go-livepeer as of now.

How did you test each of these updates (required)

  • Manual end-to-end testing with detector enabled
  • Unit tests

Does this pull request close any open issues?

Checklist:

go.mod Outdated Show resolved Hide resolved
Copy link
Contributor

@darkdarkdragon darkdarkdragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking merge for now to get #2028 merged first as a part of a release.

Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few small comments. Let's also rebase off master.

doc/gpu.md Outdated Show resolved Hide resolved
CHANGELOG_PENDING.md Show resolved Hide resolved
Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jailuthra jailuthra merged commit d7d65ca into master Sep 14, 2021
jailuthra added a commit that referenced this pull request Sep 14, 2021
@jailuthra jailuthra deleted the jai/ffmpeg-update branch September 15, 2021 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants